Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move some warn to debug #292

Merged
merged 1 commit into from
Jul 5, 2024
Merged

move some warn to debug #292

merged 1 commit into from
Jul 5, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • Making that warn to debug to not alarm users that something is wrong. If they call the methods of contract which they did not provide, they will get error anyway.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur requested a review from samlaf July 5, 2024 17:22
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I don't feel 100% convinced this is the right move here though, and expecting this hidden debug warning to result in some user pain at some point haha, but let's see. If we get issues we can change later or figure out a strategy.

@shrimalmadhur shrimalmadhur merged commit 8f12390 into dev Jul 5, 2024
4 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/move-warn-to-debuggst branch July 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants