Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mock to fake #302

Merged
merged 6 commits into from
Jul 20, 2024
Merged

chore: mock to fake #302

merged 6 commits into from
Jul 20, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur requested review from samlaf and eigen-vi July 18, 2024 22:10
@shrimalmadhur shrimalmadhur marked this pull request as ready for review July 18, 2024 22:10
@shrimalmadhur shrimalmadhur changed the title mock to fake chore: mock to fake Jul 18, 2024
samlaf
samlaf previously approved these changes Jul 20, 2024
View reviewed changes
chainio/clients/avsregistry/writer.go Show resolved Hide resolved
internal/fakes/avs_regsitry.go Outdated Show resolved Hide resolved
internal/fakes/avs_regsitry.go Outdated Show resolved Hide resolved
@samlaf samlaf dismissed their stale review July 20, 2024 08:25

need to fix typos first

@shrimalmadhur shrimalmadhur merged commit 91e8f8f into dev Jul 20, 2024
4 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/refactor-remove-interfaces-part2 branch July 20, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@eigen-vi eigen-vi Awaiting requested review from eigen-vi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf