Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eth client and logger #304

Merged
merged 9 commits into from
Jul 23, 2024
Merged

refactor: eth client and logger #304

merged 9 commits into from
Jul 23, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • Refactor ETH Client
  • Remove Noop logger.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur requested a review from samlaf July 23, 2024 00:08
samlaf
samlaf reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just have some small nits

chainio/clients/eth/client.go Show resolved Hide resolved
chainio/clients/eth/client.go Show resolved Hide resolved
chainio/clients/wallet/fireblocks_wallet.go Outdated Show resolved Hide resolved
internal/fakes/eth_client.go Show resolved Hide resolved
services/bls_aggregation/blsagg_test.go Outdated Show resolved Hide resolved
@shrimalmadhur shrimalmadhur requested a review from samlaf July 23, 2024 22:22
samlaf
samlaf previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding source info to test logger

testutils/logger.go Outdated Show resolved Hide resolved
@samlaf samlaf force-pushed the madhur/refactor-part4 branch from 7938384 to 87e3e38 Compare July 23, 2024 22:58
@samlaf samlaf merged commit 7c76ea7 into dev Jul 23, 2024
4 checks passed
@samlaf samlaf deleted the madhur/refactor-part4 branch July 23, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf