Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for delegation approver address #32

Merged
merged 4 commits into from
Oct 12, 2023
Merged

fix for delegation approver address #32

merged 4 commits into from
Oct 12, 2023

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Oct 11, 2023 •
edited
Loading

Fixes #29

Motivation

Solution

Also added a body.Close() fix

Open questions

@shrimalmadhur shrimalmadhur requested a review from samlaf October 11, 2023 21:06
samlaf
samlaf approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shrimalmadhur shrimalmadhur merged commit 5afbe24 into master Oct 12, 2023
3 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/fix-delegation-approver-validation branch October 12, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix validation of operator configuration - DelegationApproverAddress
2 participants
@shrimalmadhur @samlaf