Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add batch key create utility #35

Merged
merged 16 commits into from
Oct 17, 2023
Merged

add batch key create utility #35

merged 16 commits into from
Oct 17, 2023

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes #30

Motivation

Create a new utility for batch key creation

Solution

Open questions

@shrimalmadhur shrimalmadhur changed the title add batch key utility add batch key create utility Oct 12, 2023
@shrimalmadhur shrimalmadhur requested a review from samlaf October 12, 2023 01:24
@shrimalmadhur
Copy link
Collaborator Author

any name suggestion? geth has a utility name ethkey - I out ours as elkey

jianoaix
jianoaix previously approved these changes Oct 13, 2023
View reviewed changes
Copy link

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

samlaf
samlaf reviewed Oct 13, 2023
View reviewed changes
utils/test_data/generated/password.txt Outdated Show resolved Hide resolved
utils/test_data/generated/private_key_hex.txt Outdated Show resolved Hide resolved
cmd/elkey/README.md Outdated Show resolved Hide resolved
utils/batch_key.go Outdated Show resolved Hide resolved
utils/types.go Outdated Show resolved Hide resolved
cmd/elkey/main.go Outdated Show resolved Hide resolved
cmd/elkey/main.go Outdated Show resolved Hide resolved
utils/batch_key.go Outdated Show resolved Hide resolved
cmd/elkey/generate.go Outdated Show resolved Hide resolved
cmd/elkey/generate.go Outdated Show resolved Hide resolved
samlaf
samlaf reviewed Oct 13, 2023
View reviewed changes
cmd/egnkey/README.md Outdated Show resolved Hide resolved
@shrimalmadhur shrimalmadhur requested a review from samlaf October 13, 2023 18:07
samlaf
samlaf approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrimalmadhur shrimalmadhur merged commit 9a026d0 into master Oct 17, 2023
3 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/add-key-utils branch October 17, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@jianoaix jianoaix jianoaix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch Key creation tool
3 participants
@shrimalmadhur @samlaf @jianoaix