Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: methods to set and read operator avs split #401

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat: methods to set and read operator avs split #401

merged 3 commits into from
Dec 11, 2024

Conversation

gpabst
Copy link
Contributor

@gpabst gpabst commented Dec 6, 2024

Adds convenience methods for reading and setting operator AVS split

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@gpabst gpabst mentioned this pull request Dec 9, 2024
Merged
@gpabst gpabst changed the title WIP feat: methods to set and read operator avs split feat: methods to set and read operator avs split Dec 11, 2024
@gpabst gpabst marked this pull request as ready for review December 11, 2024 16:14
bdchatham
bdchatham previously approved these changes Dec 11, 2024
View reviewed changes
Copy link

@bdchatham bdchatham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to understand the reasoning on *uint16 and specifics on how that is going to work, but not an immediate blocker to releasing this.

chainio/clients/elcontracts/reader.go Outdated Show resolved Hide resolved
chainio/clients/elcontracts/reader.go Outdated Show resolved Hide resolved
@gpabst gpabst added this pull request to the merge queue Dec 11, 2024
Merged via the queue into dev with commit 79336bf Dec 11, 2024
4 checks passed
@gpabst gpabst deleted the george-elo-383-eigensdk-operator-avs-split branch December 11, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdchatham bdchatham bdchatham approved these changes

@shrimalmadhur shrimalmadhur Awaiting requested review from shrimalmadhur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpabst @shrimalmadhur @bdchatham