Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bls signer abstraction #403

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Dec 7, 2024

Fixes # .

What Changed?

  • Introducing a separate module for the signer. We are thinking of making eigensdk a multi module for better version management and usage experience.
  • Re-using the signer folder (which is deprecated) for new signer abstraction

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can we add some tests?

@shrimalmadhur
Copy link
Collaborator Author

lgtm, can we add some tests?

cool ya - I will add those tests and then I will also integrate with eigenda

@anupsv anupsv self-requested a review December 12, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants