Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update metadata to only allow png images #63

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

Motivation

We only want to allow png image upload to reduce surface are of image validation. IF we need other image format like jpg/jpeg, we can add that later.

Solution

  • Update validation
  • Add tests

Open questions

@shrimalmadhur shrimalmadhur requested a review from samlaf October 27, 2023 21:12
samlaf
samlaf previously approved these changes Oct 30, 2023
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 2 small typos in comments

types/operator_metadata.go Outdated Show resolved Hide resolved
types/operator_metadata.go Outdated Show resolved Hide resolved
@shrimalmadhur shrimalmadhur merged commit c396a15 into master Oct 31, 2023
3 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/image-val branch October 31, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants