Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button toggle #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ludvigeriksson
Copy link

Changes proposed in this pull request:

  • Toggles the visibility of the close button on a single tap

I wanted this in my own project, so I thought I might as well submit it. I know it hasn't been discussed, so if it isn't wanted, feel free to close it.

@LcTwisk
Copy link
Owner

LcTwisk commented May 3, 2018

Thanks for the PR! I'll definitely look at it when I've got some time. Might be nice if this feature can be enabled through the configuration so the behaviour doesn't change for existing apps.

@frboulais
Copy link

Hi there! Thx for this awesome library :) Do you plan to merge this PR soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants