Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User ID and Password Problem #30

Open
jiarongqiu opened this issue Feb 14, 2017 · 3 comments
Open

User ID and Password Problem #30

jiarongqiu opened this issue Feb 14, 2017 · 3 comments

Comments

@jiarongqiu
Copy link

Hi! I found a problem here. As you can see, the User ID and Password failed to be concealed.

{{NAME}},
  The following is a guest password that will allow you temporary view only 
 access to EnronOnline. Please note, the user ID and password are CASE 
 SENSITIVE.
 {{NAME}} User ID: GNA45925
 {{NAME}} Password: YJ53KU42
 Log in to {{URL}} and install shockwave using instructions 
 below. I have set up a composite page with western basis and cash prices to 
 help you filter through the products. The title of the composite page is 
 {{NAME}}'s Page. 
@deanmalmgren
Copy link
Collaborator

Thanks for pointing this out, @Charlie818. This is definitely a limitation of the current implementation of the current regular expression implementation. I won't have time to get to this anytime soon, but feel free to propose a PR to address the issue and I will incorporate it as promptly as I can.

@jiarongqiu
Copy link
Author

Thx for your prompt reply! I tried to fix it myself but failed, since I am not familiar with python and how things work here. And the problem about it, through my check, would be that your Regular Expression does not contain 'id', so therefore, you shall add more symbols to it, like 'id' for username and 'pwd' for password. Another reason for why things don't work in this case is that the RE don't support the middle words between 'username' and 'password', like 'Guest Username: qweas Guest Password:123'. The 'Guest' in between obstructs to recognize the case. @deanmalmgren

@jiarongqiu
Copy link
Author

Now, I can not add a layer to convert the informal pattern to the standard one in my project, so things work pretty well now. And, again, thx for your awesome package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants