Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vote] Remove most optimizations from Leaves #262

Closed
s-yh-china opened this issue Jul 19, 2024 · 39 comments
Closed

[Vote] Remove most optimizations from Leaves #262

s-yh-china opened this issue Jul 19, 2024 · 39 comments

Comments

@s-yh-china
Copy link
Member

In the early stages of 'leaves', we added certain optimizations. As of today, these optimizations may benefit the server-side, but they have significantly slowed down our development process.
Now, I propose to remove most of the optimizations in 'leaves', leaving only necessary, significant and non-intrusive ones. If removed, the optimized part might become an independent 'Leaves fork'.
This is a vote, not an announcement, you can voice your opinion through emoticons or leave a comment below.

Chinese version:
在早期的leaves中,我们曾加入了一定的优化。时至今日,这些优化可能对服务端有益处,但这大大拖慢了我们开发的进程。
在现在,我提出移除leaves中的大部分优化,只留下一些必要的,效果显著的,且不影响原版的。如果移除,优化的部分可能会成为一个单独的 Leaves fork 而存在。
这是一个投票,而不是一个公告,你可以使用表情符号发表你的意见,或者在下方留言。

@s-yh-china s-yh-china pinned this issue Jul 19, 2024
@lilingfengdev
Copy link

This is a great decision.

Most users of Leaves don't care about performance, they are looking for stock features and module support, ditching the performance optimisation patches will allow Leaves to focus on features and module support.

(and Leaf) 😄

@MC-XiaoHei
Copy link
Member

我认为这很好,保留大量效果不显著且可能破坏特性的优化并不是好的选择
I think that's fine, it's not a good idea to keep a lot of optimizations that are insignificant and may break features

如果需要更好的优化,可以期待Lumina
If you need better optimization, you can look forward to Lumina

@LittleChest
Copy link
Member

Great! Let's do more meaningful things.
If you need optimizations, you can check out some other forks (such as Leaf). 同名叶子

@Lumine1909
Copy link
Contributor

FOCUS ON FEATURES!

@Lu-Mine
Copy link

Lu-Mine commented Jul 19, 2024

非常支持。这大大减小了新服务端配置负担。
Much in favor of this! This greatly reduces the burden of configuring a new server.

“开箱即用”正是 Leaves 核心所追求的。
Out of the box = exactly what Leaves is all about, isn't it?

@CerealAxis
Copy link

Good

@Lumine1909

This comment was marked as off-topic.

@theLIKImk
Copy link

支持
.....怎么说呢,其实由于原版服务端是单核服务器,不管再怎么优化上线都是那样了(CPU-Z单核心670分的运行MC的情况都不是很理想)。
要更多优化只能期待......多线程服务端吧。

@Lu-Mine
Copy link

Lu-Mine commented Jul 19, 2024

支持 .....怎么说呢,其实由于原版服务端是单核服务器,不管再怎么优化上线都是那样了(CPU-Z单核心670分的运行MC的情况都不是很理想)。 要更多优化只能期待......多线程服务端吧。

期待(Expect) Lumina.

@xiao-k233
Copy link
Contributor

从Leaf里偷一些效果最显著的patch来?
例如AVX支持?

@s-yh-china
Copy link
Member Author

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

读书人的事,能叫偷吗

@Bluemangoo
Copy link
Member

支持 .....怎么说呢,其实由于原版服务端是单核服务器,不管再怎么优化上线都是那样了(CPU-Z单核心670分的运行MC的情况都不是很理想)。 要更多优化只能期待......多线程服务端吧。

有没有优化差别相当大。

@LittleChest
Copy link
Member

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

我们的开发重点不在优化,而且这仍然会拖慢开发速度。

@Bluemangoo

This comment was marked as off-topic.

@xiao-k233

This comment was marked as off-topic.

@xiao-k233
Copy link
Contributor

xiao-k233 commented Jul 19, 2024 via email

@LrbsX
Copy link

LrbsX commented Jul 20, 2024

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

@MC-XiaoHei
Copy link
Member

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

这要看你怎么定义 差的大

实际上在我看来leaves的性能从来都不是一个很好的卖点(诋毁

@s-yh-china
Copy link
Member Author

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

怎么都是基于paper 我觉得应该不会?

@MC-XiaoHei
Copy link
Member

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

怎么都是基于paper 我觉得应该不会?

我感觉leaves有一些功能具有未知的破坏性能的作用(

毕竟现在看起来leaves确实性能比paper差

@Bluemangoo
Copy link
Member

我们把一些大幅优化(破坏)的patch还原了。当然性能会下降。

@s-yh-china
Copy link
Member Author

很明显大家都不反对,我们即将执行(笑)

@xiao-k233
Copy link
Contributor

我反对[doge]把一些最好的补丁拿过来,能打就打,不能打算了,等别人维护好了再合

@LittleChest
Copy link
Member

我反对[doge]把一些最好的补丁拿过来,能打就打,不能打算了,等别人维护好了再合

你自己fork一个 想合什么合什么

@Mooling0602
Copy link

Mooling0602 commented Jul 22, 2024

优化的部分可能会成为一个单独的 Leaves fork 而存在

只是“可能”,也就是说有概率后面这些优化都有概率在新版本消失,因此我反对,另外关闭 issue 的速度不要太快了吧)
至于说 Folia 那种类型的服务端,我个人而言暂不会考虑,因为多线程的服务端要兼容现有的插件生态或许还需要较长的时间。

@s-yh-china
Copy link
Member Author

优化的部分可能会成为一个单独的 Leaves fork 而存在

只是“可能”,也就是说有概率后面这些优化都有概率在新版本消失,因此我反对,另外关闭 issue 的速度不要太快了吧) 至于说 Folia 那种类型的服务端,我个人而言暂不会考虑,因为多线程的服务端要兼容现有的插件生态或许还需要较长的时间。

因为确实没人提出反对(

@Mooling0602
Copy link

Mooling0602 commented Jul 22, 2024

优化的部分可能会成为一个单独的 Leaves fork 而存在

只是“可能”,也就是说有概率后面这些优化都有概率在新版本消失,因此我反对,另外关闭 issue 的速度不要太快了吧) 至于说 Folia 那种类型的服务端,我个人而言暂不会考虑,因为多线程的服务端要兼容现有的插件生态或许还需要较长的时间。

因为确实没人提出反对(

异议!doge

@s-yh-china s-yh-china reopened this Jul 22, 2024
@s-yh-china
Copy link
Member Author

那我们再开几天(

@MC-XiaoHei
Copy link
Member

我反对[doge]把一些最好的补丁拿过来,能打就打,不能打算了,等别人维护好了再合

那你来写。

@MC-XiaoHei
Copy link
Member

Reference in n

上面有emoji投票

@mc506lw
Copy link

mc506lw commented Jul 23, 2024

So cool!It was a great decision ahead of time!

@MC-XiaoHei
Copy link
Member

So cool!It was a great decision ahead of time!

also see LeavesMC/Lumina#16 plz XD

@yxc0915
Copy link

yxc0915 commented Jul 23, 2024

对于我来说,只要能够满足生电需求就行()ps:我用leaves开个小型生电服tps都只有10几,给我整不会了(CPU是13900)🌚🌚🌚

@LittleChest
Copy link
Member

对于我来说,只要能够满足生电需求就行()ps:我用leaves开个小型生电服tps都只有10几,给我整不会了(CPU是13900)🌚🌚🌚

尝试使用11/12代英特尔CPU,13代英特尔CPU有质量问题

@Bluemangoo
Copy link
Member

对于我来说,只要能够满足生电需求就行()ps:我用leaves开个小型生电服tps都只有10几,给我整不会了(CPU是13900)🌚🌚🌚

尝试使用11/12代英特尔CPU,13代英特尔CPU有质量问题

最新intel回复包赔。

@Noogear
Copy link

Noogear commented Jul 24, 2024

让我想到了一个端
https://github.com/Winds-Studio/Leaf
它就像是paper优化集合的分支

@MC-XiaoHei
Copy link
Member

让我想到了一个端 https://github.com/Winds-Studio/Leaf 它就像是paper优化集合的分支

leaf开发者和我们很熟(x

@qyl27
Copy link
Contributor

qyl27 commented Jul 27, 2024

LGTM, I would like vanilla features rather than optimizations.

@s-yh-china
Copy link
Member Author

我们注意到,并没有那么多用户支持保留优化,因此我们即将开始进行此issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests