Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typed password is not deterministic (lowercase / uppercase change) #38

Open
monperrus opened this issue Jan 21, 2023 · 11 comments · Fixed by #56
Open

typed password is not deterministic (lowercase / uppercase change) #38

monperrus opened this issue Jan 21, 2023 · 11 comments · Fixed by #56
Labels

Comments

@monperrus
Copy link

monperrus commented Jan 21, 2023

I notice that when I ask for a password with the app, some letters are randomly changed to lowercase / upercase.

On a password with 20 characters, after 26 attempts, I get 4 variations of the password.

Notably, it seems that not all character positions are equally impacted, only the 6th, 7th, 8th and 12th characters have been switched at least once.

Version 1.0.2
OS: Linux

@TamtamHero
Copy link
Contributor

I failed to reproduce it on a Nano X/Linux, which device are you using ?
This is when typing a registered password through "Type password" ?

@monperrus
Copy link
Author

monperrus commented Feb 5, 2023 via email

@monperrus
Copy link
Author

My current workaround is to use a password with only lower case.

This is a critical limitation

@lpascal-ledger
Copy link
Contributor

lpascal-ledger commented Mar 22, 2023

Are you doing your attempts on the same interface, or do you change your keyboard layout?
I've highlighted in issue #41 some unexpected behaviors while doing a few tests. In particular, with Qwerty International, I did have case changes between my console and my browser (though it remained stable on a particular interface).

@monperrus
Copy link
Author

hi @lpascal-ledger I'm not changing the keyboard layout. the random lowercase / uppercase happens with the same ledger and the same layout. thanks!

@lpascal-ledger
Copy link
Contributor

@monperrus thanks for the precision, and the report.
Can't promise you it'll be fixed shortly, but we plan to commit significant time into fixing / improving this app and some other non-cryptocoin apps (such as SSH, PGP, etc.).

@monperrus
Copy link
Author

monperrus commented Mar 27, 2023 via email

@lpascal-ledger
Copy link
Contributor

lpascal-ledger commented Oct 24, 2023

Investing this, I encountered this issue but only in my day-to-day console (basic terminator without much config).
I could not reproduce on other any application (browser, default Ubuntu terminal, text editor, ...).
The USB trace seems correct. The MAJ flag is correctly put on every uppercase character.

On which application did you have this problem @monperrus?

@monperrus
Copy link
Author

monperrus commented Oct 24, 2023 via email

@lpascal-ledger
Copy link
Contributor

Keeping this open until I got a feedback on the latest fix pushed.

@monperrus
Copy link
Author

monperrus commented Mar 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants