✨ (core) [NO-ISSUE]: Event based device session refresher using rxjs #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
valpinkman
force-pushed
the
feature/no-issue-rx-events
branch
2 times, most recently
from
bbbb7c1
to
eb678e5
Compare
valpinkman
force-pushed
the
feature/no-issue-rx-events
branch
from
eb678e5
to
e5884ae
Compare
valpinkman
force-pushed
the
feature/no-issue-rx-events
branch
from
e5884ae
to
b0084da
Compare
| } from "@ledgerhq/device-sdk-core"; | ||
|
|
||
| export const sdk = new DeviceSdkBuilder() | ||
| .addLogger(new ConsoleLogger()) | ||
| .addLogger(new ConsoleLogger(LogLevel.Info)) |
There was a problem hiding this comment.
[SHOULD] put back to no arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update the DeviceSessionRefresher component to use an event based system to update it's state
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
🧐 Checklist for the PR Reviewers