Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VG-15990): add stax nft clearsign screens #220

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

ndedouhet-ledger
Copy link
Contributor

The logic in the HSM code differs between Blue and Stax.

  • Blue: NFT function screens are described in parsers.json and the final screen flow is a concatenation of those function screens with the sci clear sign screens defined in the crypto-assets repo
  • Stax: NFT clearsign screens are fully described under ethereum/nft/parsers.json. There is not concatenation

@ndedouhet-ledger ndedouhet-ledger requested a review from a team as a code owner September 18, 2024 13:39
@ndedouhet-ledger ndedouhet-ledger changed the title feat(stax): add nft clearsign screens feat(VG-15990): add stax nft clearsign screens Sep 18, 2024
Copy link

@pandouard pandouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndedouhet-ledger ndedouhet-ledger merged commit b355869 into main Sep 20, 2024
3 checks passed
@ndedouhet-ledger ndedouhet-ledger deleted the feat/stax-nft-clearsign branch September 20, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants