Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential off by one in ChannelEvent Channel field #17

Open
peterbekos opened this issue Mar 4, 2018 · 1 comment
Open

Potential off by one in ChannelEvent Channel field #17

peterbekos opened this issue Mar 4, 2018 · 1 comment

Comments

@peterbekos
Copy link

I think there's an off by one error in the channel for ChannelEvent objects. I know drums are always supposed to be on channel 10 but in the lib it comes back as 9. Cross referenced this with my DAW

@peterbekos
Copy link
Author

Also I see this:

    public void setChannel(int c)
    {
        if(c < 0)
        {
            c = 0;
        }
        else if(c > 15)
        {
            c = 15;
        }
        mChannel = c;
    }

the reason I'm not so adamant about this being a bug is because maybe the goal is to reflect the data and not the actual number the users would see when interacting with channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant