-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more healthly way to access to iconsjson string #17
Conversation
@hawl1 since the Build are failing, can you say me what to change in the build.yml file to make it work again (since I'm sure your code is clean) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
its because i dont have a vercel token |
oh wait, its because vercel thinks that icons.go is a function |
No, I've done a special one to check if it can at least build, if the code builds, it's all good to be merged, look build.yml file |
Oh yes wait, it does also no want to deploy too, so no workflow works at all... yeah idk, that seems strange |
after looking around, vercel just dont like variables on seperate files... |
No Problem, I did undertsand what you wanted to do and is literally the way to do, (ran go run build.go then looked at the index.go file and my neovim had a struggle with it xD), I'm going to revert it but no problem, it was done for good purposes so no problem brother ;) |
)" This reverts commit 2d31066.
it really makes an issue to be honest.