Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clerk icon #279

Merged
merged 1 commit into from
Nov 21, 2024
Merged

added clerk icon #279

merged 1 commit into from
Nov 21, 2024

Conversation

Nikhar-savaliya
Copy link
Contributor

Add New Icon

Icon Details

Icon ID Icon
clerk-light image
clerk-dark image

Notes

  • Provide any specific notes about the new icon(s), such as design choices, color adjustments, etc.
  • Mention if there were any deviations from the standard style or guidelines.

Checklist

  • Added icon(s) to the appropriate directory
  • Updated documentation with the new icon(s)
  • Verified the icon(s) display correctly
  • If the icon has light and dark, verified the auto switch works correctly
  • The Svg does not contain any sort of strokes

@Nikhar-savaliya Nikhar-savaliya changed the title added clerk icon #278 added clerk icon Nov 12, 2024
@Nikhar-savaliya Nikhar-savaliya marked this pull request as ready for review November 12, 2024 08:33
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that making only one version could be better ?

Because if the light version does not have the light color, you can make it a single icon I guess.

Else it looks good to me :)

@Nikhar-savaliya
Copy link
Contributor Author

Thank you for the feedback! I'll remove the extra icons and keep a single icon for simplicity.

Would you recommend keeping the dark version or the light version?

@LelouchFR
Copy link
Owner

Thank you for the feedback! I'll remove the extra icons and keep a single icon for simplicity.

Would you recommend keeping the dark version or the light version?

I think the light version is better, so you can remove the dark one and rename clerk-light to clerk.

LelouchFR
LelouchFR previously approved these changes Nov 21, 2024
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LelouchFR
Copy link
Owner

LelouchFR commented Nov 21, 2024

@Nikhar-savaliya can you resolve the conflict in the readme file ?

Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you :)

@LelouchFR LelouchFR merged commit 4b9209a into LelouchFR:main Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants