Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: microsoft teams #5

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: microsoft teams #5

merged 1 commit into from
Jul 3, 2024

Conversation

chesha1
Copy link
Contributor

@chesha1 chesha1 commented Jul 3, 2024

I added some new Microsoft teams, and we need to clarify which types of teams (GitHub accounts) will be included.

Using Microsoft as an example, there are some controversial teams:

  • Archive Accounts, e.g., Microsoft Archive. These accounts make minor improvements to their forked repos.
  • Docs Accounts, e.g., Microsoft Docs. These accounts generally host documentation rather than code.
  • Service Accounts, e.g., Azure SDK Bot. These accounts often act as bots in the company's internal pipeline.

I think the latter two types of accounts can be included, while the first type should not be. Credits should be given to the original organization.

I'm not saying forked repos shouldn't be considered, but repos in archive accounts mainly hold the current state without many new features or fixes.

Another situation involves subsidiaries, like GitHub being a subsidiary of Microsoft. To simplify, it's better to consider the parent company and its subsidiaries as one entity.

This PR includes all of the controversial teams. Please do not merge it until we determine which types of teams can be included.

@LeslieLeung
Copy link
Owner

Created #6 to discuss this topic.

@chesha1
Copy link
Contributor Author

chesha1 commented Jul 3, 2024

According to discussion in #6, there are no teams need to add or remove about microsoft as this pr have included all of the three types of accounts mentioned above.

Please review again to check if there is anything to do about this PR.

@LeslieLeung LeslieLeung merged commit f338560 into LeslieLeung:main Jul 3, 2024
3 of 4 checks passed
@chesha1 chesha1 deleted the teams branch July 3, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants