Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save designspace with unsaved open UFO #101

Open
typemytype opened this issue Oct 23, 2024 · 2 comments
Open

save designspace with unsaved open UFO #101

typemytype opened this issue Oct 23, 2024 · 2 comments

Comments

@typemytype
Copy link
Collaborator

popup a warning to save the unsaved UFO first

Traceback (most recent call last):
  File "/Users/frederik/Documents/dev/typesupply/vanilla/Lib/vanilla/dialogs.py", line 181, in completionHandler_
    self._resultCallback(self._result)
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/DesignspaceEditor2.roboFontExt/lib/designspaceEditor/ui.py", line 1969, in saveDesignspace
    sourceDescriptor.filename = os.path.relpath(sourceDescriptor.path, root)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 509, in relpath
ValueError: no path specified
Traceback (most recent call last):
  File "/Users/frederik/Documents/dev/typesupply/vanilla/Lib/vanilla/dialogs.py", line 181, in completionHandler_
    self._resultCallback(self._result)
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/DesignspaceEditor2.roboFontExt/lib/designspaceEditor/ui.py", line 1969, in saveDesignspace
    sourceDescriptor.filename = os.path.relpath(sourceDescriptor.path, root)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 509, in relpath
ValueError: no path specified
@typemytype
Copy link
Collaborator Author

or save those unsaved UFO next to the designspace path? @LettError

@LettError
Copy link
Owner

Maybe DSE should show a dialog "Save the sources first"

typemytype added a commit that referenced this issue Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants