-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style linking names for instances #91
Comments
I hear you. I know these names are useful to set if you're aiming for UFOs. I think there was some reluctance as the columns are crowded and there will be more values that one might need to be set. Weight and width values, if the interpolated numbers need to be adjusted. This is not to dismiss the request, but we need to think about where it should go. @typemytype what do you think? |
Ok! |
I'm on it |
it happens here: https://github.com/LettError/designSpaceRoboFontExtension/blob/master/DesignspaceEditor2.roboFontExt/lib/designspaceEditor/ui.py#L556-L591 and not on ezui (yet.. ) |
@typemytype @LettError Draft PR #92 |
I think Colin makes the case that not all designspaces will be variable fonts. Unless we want UFOOperator to also compile the STAT. |
no, an operator should not compile this (it has a preview through fontTools) but its good when those values are available |
Hi @LettError —
In the DS5 spec there are additional names available other than what is shown in the instances tab.
https://fonttools.readthedocs.io/en/latest/designspaceLib/xml.html#instances-element
Most important of those, I think, are the
stylemapfamilyname
andstylemapstylename
elements. These are quite useful for getting style linking to work in static fonts generated from the instances in a Designspace document. If they are left unset, the build tool just makes a best guess as to what NID 1 and 2 in thename
table should be, and it could be wrong. I always find myself adding these names in the XML afterwards, which is fine for me but might be confusing for others.It would be nice to have these names on the instance tab. If not in the table (I know it is quite crowded there and clutter should be kept to a minimum), maybe it could be the first tab on the "info" popup (which currently contains settings for localized names).
If this sounds like an idea you would like to see, I can make a PR to that effect.
The text was updated successfully, but these errors were encountered: