Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cipher to aes-128-gcm #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sieveLau
Copy link
Contributor

@sieveLau sieveLau commented May 26, 2021

What this does:

  1. split the javascript used for decryption into a seperate file
  2. change cipher from aes-cbc to aes-gcm

About 1, pros and cons are described in #20

Reasons for 2:

Dependencies changed:

  • CryptoJS doesn't support aes-gcm, I use forge to fulfil the requirement
  • pycrypto doesn't support aes-gcm, I use pycryptodome to fulfil that

@sieveLau sieveLau changed the title Dev aes gcm change cipher to aes-128-gcm May 26, 2021
@sieveLau
Copy link
Contributor Author

If we accept to use aes-gcm to encrypt the content, the password hashing part would be the next part to be strengthened. After all, md5 is too fast for password hashing, but we need a slow one.

On the other hand, if the encryptor is fed with a lot of htmls which require encryption, the hashing algorithm can't be slow.

@sieveLau sieveLau mentioned this pull request Jun 4, 2021
@zerofancy
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants