Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting definitions #47

Open
fdrobnic opened this issue Jan 5, 2021 · 1 comment
Open

Conflicting definitions #47

fdrobnic opened this issue Jan 5, 2021 · 1 comment

Comments

@fdrobnic
Copy link

fdrobnic commented Jan 5, 2021

In the libraries/SensorXtr/WaspSensorXtr.h, there is a conflicting definition:

#define MCP_GP1 1 // Unconneted MCP GPIO
#define MCP_GP1 0 // Unconneted MCP GPIO

Possibly, this is due to copy-paste error and the second definition should define MCP_GP0. Additionally, in the corresponding WaspSensorXtr.cpp, there are two identical lines:

mcp.pinMode(MCP_GP1, INPUT);
mcp.pinMode(MCP_GP1, INPUT);

The second line should probably refer to MCP_GP0.

These conflicts do not cause any serious problems, only some warnings during compilation.

There is another warning caused by some headers reorganization:

c:\libelium\waspmote-pro-ide-v06.21\hardware\tools\avr\avr\include\avr\parity.h:36:2: warning: #warning "This file has been moved to <util/parity.h>." [-Wcpp]

@Libelium
Copy link
Owner

Libelium commented Jan 7, 2021

Hi fdrobnic,

Thanks for your collaboration, we will correct this bug in the next API release.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants