Skip to content

Commit

Permalink
Merge pull request #3891 from LibreSign/fix/deprecated
Browse files Browse the repository at this point in the history
Fix/deprecated
  • Loading branch information
vitormattos authored Nov 5, 2024
2 parents 462f9eb + 719411e commit 38900c6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
3 changes: 1 addition & 2 deletions lib/Db/SignRequestMapper.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace OCA\Libresign\Db;

use Doctrine\DBAL\Platforms\PostgreSQLPlatform;
use OCA\Libresign\Helper\Pagination;
use OCA\Libresign\Service\IdentifyMethod\IIdentifyMethod;
use OCA\Libresign\Service\IdentifyMethodService;
Expand Down Expand Up @@ -442,7 +441,7 @@ private function getFilesAssociatedFilesWithMeQueryBuilder(string $userId, ?arra
// when the database is PostgreSQL. The problem is that the command
// addGroupBy add quotes over all text send as argument. With
// PostgreSQL json columns don't have problem if not added to group by.
if (!$qb->getConnection()->getDatabasePlatform() instanceof PostgreSQLPlatform) {
if ($qb->getConnection()->getDatabaseProvider() !== IDBConnection::PLATFORM_POSTGRES) {
$qb->addGroupBy('f.metadata');
}

Expand Down
5 changes: 0 additions & 5 deletions tests/psalm-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@
<code><![CDATA[QueryBuilder]]></code>
</UndefinedClass>
</file>
<file src="lib/Db/SignRequestMapper.php">
<UndefinedClass>
<code><![CDATA[PostgreSQLPlatform]]></code>
</UndefinedClass>
</file>
<file src="lib/Files/TemplateLoader.php">
<InvalidArgument>
<code><![CDATA[addServiceListener]]></code>
Expand Down

0 comments on commit 38900c6

Please sign in to comment.