Signer is not sent an activity notification when signature is requested

[DazeEnd]

Describe the bug
A user with a Nextcloud account should receive a notification when his signature is requested. Currently, no notification is sent.

To Reproduce

1. As a regular Nextcloud user, log into your account. Open Settings > Notifications, and make sure that the "Mail" checkbox is selected for all notification options, and that "As soon as possible" is selected for the "Send activity emails" option.
   

2. Log in as an admin user and request a signature from the regular Nextcloud user from Step 1.

3. Wait 10 minutes.

Expected behavior
The regular user whose signature was requested should receive an email notification informing him that his signature has been requested.

Actual behavior
No email notification is sent. This was verified by looking at the logs of my SMTP server.

Screenshots

Environment information (please complete the following information):

• OS: AlmaLinux 8.9
• Browser: Chrome
• LibreSign Version: v8.0.0-rc6
• Nextcloud Server Version: v28.0.2
• Logs (get the entries from nextcloud.log related with LibreSign i.e tail -f data/nextcloud.log|grep libresign): No messages are logged when performing these steps

Additional context
When a signature is requested from an email address that does not have a Nextcloud account, that email address does receive an email notification.

[DazeEnd]

Tested in LibreSign 8.0.0-rc7 running on Nextcloud 28.0.2.

I logged in as the regular user, went to Settings > Notifications, and turned on the new "You have a file to sign" notfication:

Logging into Nextcloud as the admin user, I requested a signature from the regular user and waited for a notification to arrive via email. After a few minutes, this email arrived:

Although the email did arrive, it did not contain the information that I expected. As you can see, the email only says that "There was some activity at Nextcloud". At minimum, I expected the email to indicate that the activity that I am being notified about is that there is a new file to sign, and indicate what the name of the file is. It would also be great if there was a button that took the user to the file, but that is not strictly necessary.

In general, I would expect the notification email to either look like all the other activity notification emails that are sent by Nextcloud, or like the existing notification emails that LibreSign sends when a signature is requested from an email address

Here are some mockups:

Mock-up: LibreSign notification modeled on other activity notifications. (This is my preferred solution, since it integrates with with activity notifications the user is already receiving.)

Mock-up: LibreSign notification modeled on existing LibreSign emails.

[DazeEnd]

Looking more closely at the emails, it appears that you might have already been attempting to use the standard activity emails, as in the first mock-up above. However, it looks like the activity didn't properly register.

In case it is important, I will point out that LibreSign did not add an activity notification in the Activities app either:

[vitormattos]

I reopened this issue to check more.

In my environment I'm receiving this email:

[DazeEnd]

I just shared a file to see if I could get Files to generate an activity email, and everything seems to be working as expected outside of LibreSign:

I just checked, and the string "libresign" does not appear in nextcloud.log.

[vitormattos]

Is working to me:

[DazeEnd]

Let me turn off SELinux, reboot, and try again.

[vitormattos]

Did you enabled here? The last option.

[DazeEnd]

Yes, the "You have a file to sign" activity is turned ON:

I have turned off SELinux and rebooted:

[ceperry@newton ~]$ sestatus
SELinux status:                 disabled

I uploaded a new document and requested a signature on the document. My next notification email showed the files activity of uploading the file, but there was no activity from LibreSign:

[vitormattos]

Not related about email, but I identified that Activity app have a class called Filter to be possible display the activities at Activity app. I'm implementing this now, maybe will help to check if you are receiving the notifications.

[vitormattos]

@DazeEnd could you check if is ok looking the screenshots here #2509 ?
I will wait your review to don't send new words to translators because this PR changed and created texts.

[DazeEnd]

@vitormattos Sorry for the delay in getting back to you. The screenshots look good to me.

The notifications include the message, "admin requested your signature on document." In this message, will "document" be replaced with the name of the file? For example, "admin requested your signature on Perry Contract.pdf"? If yes, then it's fine.

However, if "document" will not be replaced, and it will always read "[username] requested your signature on document", then I think it should be slightly reworded to say "[username] requested your signature on a document".

[vitormattos]

The document name in my case is document 😅
Low creativity for a decent name.

libresign/tests/integration/features/sign/request.feature

Lines 192 to 195 in 831d7e9

	When sending "post" to ocs "/apps/libresign/api/v1/request-signature"
	| file | {"url":"<BASE_URL>/apps/libresign/develop/pdf"} |
	| users | [{"identify":{"account":"signer1"}}] |
	| name | document |

Only a curiosity about this step: The API have the possibility to set the file name but I didn't implemented that at frontend.

[DazeEnd]

Testing on RC8, this problem seems to be mostly fixed, but not completely fixed.

When I request a signature from a user with a Nextcloud account, the user whose signature was requested receives the following notifications:

1. The user immediately receives an email informing him that his signature has been requested. (See "Screenshot 1", below.)
2. The user later receives an activity email notifying the user that LibreSign made changes to a document. (See "Screenshot 2", below.)
3. The user has an activity posted in the Activity app, saying that the requesting user made changes to a document. (See "Screenshot 3", below.)

What still seems to be missing is an activity indicating that someone "requested your signature" on the document, as illustrated in screenshots in #2509. (See "Screenshots from Issue 2509", below.)

Screenshot 1:

Screenshot 2:

Screenshot 3:

Screenshots from Issue 2509:

[vitormattos]

Hi, I will reopen this issue and do a best check.

[vitormattos]

Fixed by:

• Store notification history at sign_request table #2573

[vitormattos]

Fixed at: https://github.com/LibreSign/libresign/releases/download/v8.0.0-rc9/libresign-v8.0.0-rc9.tar.gz

[DazeEnd]

This is fixed for me in v8.0.0-rc9.