Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve cfssl validation #3935

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

vitormattos
Copy link
Member

Related with: #3747

- Remove the backtick operator https://www.php.net/manual/en/language.operators.execution.php
- Return more information when got error
- Validate if the command to check version return empty string
- Validate the output format of version command
- Return Runtime version

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos added this to the Next Major (31) milestone Nov 13, 2024
@vitormattos vitormattos self-assigned this Nov 13, 2024
@vitormattos
Copy link
Member Author

/backport to stable30

@vitormattos
Copy link
Member Author

/backport to stable29

@vitormattos vitormattos merged commit 529aaa7 into main Nov 13, 2024
60 checks passed
@vitormattos vitormattos deleted the chore/improve-cfssl-validation branch November 13, 2024 20:41
@backportbot-libresign
Copy link

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/3935/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 63b5d2ec

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3935/stable29

Error: Failed to push branch backport/3935/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@vitormattos
Copy link
Member Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4. to release
Development

Successfully merging this pull request may close these issues.

1 participant