Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari/Remixer Regex Compatibility #150

Open
ethanaturner opened this issue Sep 25, 2021 · 1 comment
Open

Safari/Remixer Regex Compatibility #150

ethanaturner opened this issue Sep 25, 2021 · 1 comment

Comments

@ethanaturner
Copy link
Member

Description

The OER Remixer does not load in several versions of the Safari browser.

Current Insights

Remixer loading appears to be blocked due to several issues with regular expressions in the Remixer source code due to an invalid group specifier name issue. Removing these regexes (not an acceptable fix) appears to allow the Remixer to load.

Affected Environments

The issue primarily appears to affect the Safari browser. It is unclear if the issue is limited solely to macOS.

Possible Fixes

Several regular expressions within Remixer may need to be rewritten to avoid using Lookbehind.

@Miniland1333
Copy link
Member

New version of macOS and iOS finally support lookbehinds in v16.4 and above (March 26 2023) https://caniuse.com/?search=lookbehind.

I would recommend testing that this issue is now fixed on these newest version of safari, and if so this issue can be closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants