Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote packet doesn't decrease wire length #158

Open
rsanger opened this issue Dec 11, 2020 · 0 comments
Open

Demote packet doesn't decrease wire length #158

rsanger opened this issue Dec 11, 2020 · 0 comments
Labels

Comments

@rsanger
Copy link
Contributor

rsanger commented Dec 11, 2020

There is likely a bug in demote_packet(), when removing a Linux SLL header (which libtrace treats as a link-layer header) from a packet the code doesn't decrease the wire length only the capture length. I've only added code to decrease it in the pcap: case to reverse the actions applied by promote_packet().

See:

/* TODO: should we change the wirelen here too? */

cd8cd74

@rsanger rsanger added the bug label Dec 11, 2020
@rsanger rsanger changed the title Demote packet Demote packet doesn't decrease wire length Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant