Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling trace_set_hasher() for ndag inputs can cause lock-ups, segfaults #202

Open
salcock opened this issue Mar 16, 2022 · 0 comments
Open
Labels
bug core library Specific to the core libtrace library

Comments

@salcock
Copy link
Contributor

salcock commented Mar 16, 2022

ndag inputs are already effectively hashed as a result of the packets arriving over multiple multicast streams, so any calls to trace_set_hasher() on an ndag libtrace_t should be ignored and print a warning message that the hasher will have no effect.

Currently, calling trace_set_hasher() on ndag inputs can cause lock ups (e.g. if an ordered combiner is involved) and/or segfaults. I assume this is because the libtrace hasher is not well suited to input sources where the packets are already distributed somehow.

Longer term, it may be worth writing a tool that can "re-hash" an ndag-like input so that users who REALLY want to enforce a different hashing method on any already distributed input can do so, e.g. telescope ndag is distributed as round-robin, but a user might require bidirectional flow based hashing for their analysis to work.

@salcock salcock added bug core library Specific to the core libtrace library labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core library Specific to the core libtrace library
Projects
None yet
Development

No branches or pull requests

1 participant