Add the Logic to Handle "Others" Purchase Type #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inus/choosing_optimal_card
…inus/choosing_optimal_card
…inus/choosing_optimal_card
…rd' into linus/choosing_optimal_card
…inus/choosing_optimal_card # Conflicts: # app/src/main/java/edu/card/clarity/repositories/creditCard/CreditCardRepositoryBase.kt
LideLinusZhang
requested review from
rachellefontanilla,
sophiec103,
jeanniezhang,
NandiniMeh and
SamuelLiSiyuan
LideLinusZhang
changed the title
…inus/choosing_optimal_card
NandiniMeh
approved these changes
Jul 23, 2024
sophiec103
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say we want to purchase something at Canadian Tire, but none of our credit cards has a home improvement purchase reward. In this situation, the app should use "Others" purchase reward to determine the reward amount. This PR adds this logic and a safeguard to ensure there won't be a null reference exception.