Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong access level in trait #5

Open
Nks opened this issue Apr 2, 2019 · 1 comment
Open

Wrong access level in trait #5

Nks opened this issue Apr 2, 2019 · 1 comment

Comments

@Nks
Copy link

Nks commented Apr 2, 2019

Inside trait we have
/** * The data to sync to QuickBooks. * * @see https://developer.intuit.com/docs/api/accounting * @return array */ abstract protected function getQuickBooksArray(): array;

But inside interface we have

public function getQuickBooksArray();

Then it cause the error:

Access level to LifeOnScreen\LaravelQuickBooks\QuickBooksEntity::getQuickBooksArray() must be public (as in class LifeOnScreen\LaravelQuickBooks\QuickBookable)

@ingluife
Copy link

I have the same issue.
I think that getQuickBooksArray method should be only in the abstract class because the methods in the Interface are public contact, the protected methods corresponding to internal functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants