Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eventually...] Add tests for boto3 #460

Open
yifanwu opened this issue Dec 14, 2021 · 0 comments
Open

[Eventually...] Add tests for boto3 #460

yifanwu opened this issue Dec 14, 2021 · 0 comments
Labels
hygiene P2 Nice to have or need to have but in the future

Comments

@yifanwu
Copy link
Contributor

yifanwu commented Dec 14, 2021

What: As part of slicing the side effects, we should test for S3. Currently, I'm just testing it on my local machine.

As suggested by this SO post, the Stubber from botocore would have been a great candidate, but its apparently a known limitation that the stubber doesn't work for anything file related...

Possible Approaches: We might have to stub our own HTTP requests or just setup a test bucket? Neither seems great ¯_(ツ)_/¯ low pri for now.
@yifanwu yifanwu added hygiene P2 Nice to have or need to have but in the future labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hygiene P2 Nice to have or need to have but in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yifanwu