From bfdecd4dee3074e81b710e5f4a67ed3807fef5ec Mon Sep 17 00:00:00 2001 From: Lionel Zoubritzky Date: Fri, 7 Jun 2024 11:10:11 +0200 Subject: [PATCH] Fix retrieve_track! including the input ring --- Project.toml | 2 +- src/algorithms/rings.jl | 1 - test/runtests.jl | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Project.toml b/Project.toml index 723fc55..ea140a5 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "PeriodicGraphs" uuid = "18c5b727-b240-4874-878a-f2e242435bab" authors = ["Lionel Zoubritzky lionel.zoubritzky@gmail.com"] -version = "0.10.0" +version = "0.10.1" [deps] Graphs = "86223c79-3864-5bf0-83f7-82e725a168b6" diff --git a/src/algorithms/rings.jl b/src/algorithms/rings.jl index 912ff59..ead9089 100644 --- a/src/algorithms/rings.jl +++ b/src/algorithms/rings.jl @@ -1325,7 +1325,6 @@ function retrieve_track!(ret::Vector{Int32}, buffer::Vector{Int32}, gauss::Itera track = sort!(first(gauss.track)) tracks = last(gauss.track) empty!(ret) - push!(ret, length(gauss.rings)) while !isempty(track) x = pop!(track) push!(ret, x) diff --git a/test/runtests.jl b/test/runtests.jl index 04a8771..bd15da9 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -799,13 +799,13 @@ end notindependent, info = PeriodicGraphs.gaussian_elimination(gausstrack, [1, 4, 5, 7]) @test notindependent @test PeriodicGraphs.gaussian_elimination!(gausstrack, [1, 4, 5, 7], notindependent, info) - @test PeriodicGraphs.retrieve_track!(gausstrack) == Int32[5, 4, 1] + @test PeriodicGraphs.retrieve_track!(gausstrack) == Int32[4, 1] @test !PeriodicGraphs.gaussian_elimination!(gausstrack, [3, 5, 6, 7]) @test !PeriodicGraphs.gaussian_elimination!(gausstrack, [2, 3]) @test !first(PeriodicGraphs.gaussian_elimination(gausstrack, [1, 2, 3])) @test !PeriodicGraphs.gaussian_elimination!(gausstrack, [1, 2, 3]) @test PeriodicGraphs.gaussian_elimination!(gausstrack, [1, 2, 3]) - @test PeriodicGraphs.retrieve_track!(gausstrack) == Int32[9, 8] + @test PeriodicGraphs.retrieve_track!(gausstrack) == Int32[8] @test gausstrack.shortcuts == Int32[4, 7, 1, 2, 6, 3, 8] @test length(gausstrack.rings) == 9