Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry assertion if an OpenQA.Selenium.InvalidSelectorException is thrown #84

Open
JackHerring opened this issue Jul 31, 2019 · 0 comments

Comments

@JackHerring
Copy link
Contributor

If you do e.g. .Assert( x => x.CustomAssertion( y => y.FindElementsByCssSelector( "i am not a valid selector" ).SomeAssertion() ) ) then Xenon will keep trying (courtesy of WaitUntil in BaseXenonTest) until the configured wait time expires. Obviously, it will never work so this is pointless.

WaitUntil should catch these specific terminal exceptions first and bail immediately before swallowing generic ones and retrying (see line BaseXenonTest line 29)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant