Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECR repository temporally #45

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented May 14, 2024

What was the problem?

Update ECR to use lisk-token-claim repo

@shuse2 shuse2 self-assigned this May 14, 2024
@shuse2 shuse2 requested review from Nazgolze and Phanco May 14, 2024 13:56
Copy link
Member

@Nazgolze Nazgolze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this approach could work, approved 👍

@shuse2 shuse2 merged commit 2cf2aee into development May 14, 2024
1 check passed
@shuse2 shuse2 deleted the update-registry-temp branch May 14, 2024 14:02
shuse2 added a commit that referenced this pull request May 14, 2024
* Update ECR repository temporally (#45)

chors: update ECR repository temporally

* Update task definition container-name (#47)

chors: Update task definition container-name

* add password handling (#48)

* Update github yaml

---------

Co-authored-by: shuse2 <[email protected]>
Phanco added a commit that referenced this pull request May 15, 2024
* Update Taking Snapshot document

* Update ECR repository temporally (#45)

chors: update ECR repository temporally

* Update task definition container-name (#47)

chors: Update task definition container-name

* Update document formatting

* Update formatting

* Apply suggestions from code review

* Update documentation/Taking_Snapshot.md

Co-authored-by: Himanshu Nagda <[email protected]>

---------

Co-authored-by: shuse2 <[email protected]>
Co-authored-by: Himanshu Nagda <[email protected]>
Phanco added a commit that referenced this pull request May 15, 2024
* Update Taking Snapshot document

* Update ECR repository temporally (#45)

chors: update ECR repository temporally

* Update task definition container-name (#47)

chors: Update task definition container-name

* Update document formatting

* Update formatting

* Apply suggestions from code review

* Update documentation/Taking_Snapshot.md

Co-authored-by: Himanshu Nagda <[email protected]>

---------

Co-authored-by: shuse2 <[email protected]>
Co-authored-by: Himanshu Nagda <[email protected]>
Phanco added a commit that referenced this pull request May 15, 2024
* Update Taking Snapshot document

* Update ECR repository temporally (#45)

chors: update ECR repository temporally

* Update task definition container-name (#47)

chors: Update task definition container-name

* Update document formatting

* Update formatting

* Apply suggestions from code review

* Update documentation/Taking_Snapshot.md

Co-authored-by: Himanshu Nagda <[email protected]>

---------

Co-authored-by: shuse2 <[email protected]>
Co-authored-by: Himanshu Nagda <[email protected]>
Phanco added a commit that referenced this pull request May 15, 2024
* Update Taking Snapshot document

* Update ECR repository temporally (#45)

chors: update ECR repository temporally

* Update task definition container-name (#47)

chors: Update task definition container-name

* Update document formatting

* Update formatting

* Apply suggestions from code review

* Update documentation/Taking_Snapshot.md

Co-authored-by: Himanshu Nagda <[email protected]>

---------

Co-authored-by: shuse2 <[email protected]>
Co-authored-by: Himanshu Nagda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants