Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Record section titles information incorrectly #169

Open
realmx2 opened this issue Aug 9, 2024 · 1 comment
Open

DNS Record section titles information incorrectly #169

realmx2 opened this issue Aug 9, 2024 · 1 comment

Comments

@realmx2
Copy link

realmx2 commented Aug 9, 2024

Running a check on a site at: https://web-check.as93.net/

In the "DNS Records" box - the records shown are out of order and not titled correctly.

In the example below you can see that under "CNAME" it has the Nameservers, and under NS it appears to be showint TXT records...
image

@berend-debug
Copy link

There is an incorrect mapping of the lookup results due to the fact that the const that holds these results expects 9 results, while 10 lookups are being perfomed:

    const [a, aaaa, mx, txt, ns, cname, soa, srv, ptr] = await Promise.all([
      lookupPromise(hostname),
      resolve4Promise(hostname).catch(() => []), // A record
      resolve6Promise(hostname).catch(() => []), // AAAA record
      resolveMxPromise(hostname).catch(() => []), // MX record
      resolveTxtPromise(hostname).catch(() => []), // TXT record
      resolveNsPromise(hostname).catch(() => []), // NS record
      resolveCnamePromise(hostname).catch(() => []), // CNAME record
      resolveSoaPromise(hostname).catch(() => []), // SOA record
      resolveSrvPromise(hostname).catch(() => []), // SRV record
      resolvePtrPromise(hostname).catch(() => [])  // PTR record
    ]);

lookupPromise() should be removed, or an extra entry in to the const that accounts for the results of lookupPromise() should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants