cmake: Do not prefix IMGUR_API_KEY

This variable is supplied via Github Actions secret, so better to keep the name.
Sometimes it is set directly from Github Actions for platform that do not have a
build.sh (like Windows).

dist/android/build.sh

@@ -11,7 +11,7 @@ fi
 
 export QT_HOST_PATH="${QT_ROOT_DIR}/../gcc_64"
 export CMAKE_PREFIX_PATH=${QT_ROOT_DIR}/lib/cmake
-cmake .. -DQT_DEBUG_FIND_PACKAGE=ON -DCMAKE_BUILD_TYPE=Release -DLITH_IMGUR_API_KEY=$IMGUR_API_KEY -DCMAKE_INSTALL_PREFIX=installed -DCMAKE_TOOLCHAIN_FILE=$QT_ROOT_DIR/lib/cmake/Qt6/qt.toolchain.cmake -DANDROID_OPENSSL_PATH="${ANDROID_OPENSSL_PATH}" -DQT_ANDROID_BUILD_ALL_ABIS=ON
+cmake .. -DQT_DEBUG_FIND_PACKAGE=ON -DCMAKE_BUILD_TYPE=Release -DIMGUR_API_KEY=$IMGUR_API_KEY -DCMAKE_INSTALL_PREFIX=installed -DCMAKE_TOOLCHAIN_FILE=$QT_ROOT_DIR/lib/cmake/Qt6/qt.toolchain.cmake -DANDROID_OPENSSL_PATH="${ANDROID_OPENSSL_PATH}" -DQT_ANDROID_BUILD_ALL_ABIS=ON
 
 cmake --build . --target Lith -- -j2
 cmake --build . --target apk -- -j2

dist/ios/build.sh

@@ -6,7 +6,7 @@ mkdir build_ios
 cd build_ios
 
 export QT_HOST_PATH="${QT_ROOT_DIR}/../macos"
-cmake .. -GXcode -DCMAKE_PREFIX_PATH=$QT_ROOT_DIR -DCMAKE_OSX_SYSROOT=iphoneos -DCMAKE_OSX_ARCHITECTURES=arm64 -DCMAKE_TOOLCHAIN_FILE=$QT_ROOT_DIR/lib/cmake/Qt6/qt.toolchain.cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLITH_VERSION=$VERSION_NAME -DIOS_DEVELOPMENT_TEAM_ID=Z52EFCPL6D -DLITH_IMGUR_API_KEY=$IMGUR_API_KEY
+cmake .. -GXcode -DCMAKE_PREFIX_PATH=$QT_ROOT_DIR -DCMAKE_OSX_SYSROOT=iphoneos -DCMAKE_OSX_ARCHITECTURES=arm64 -DCMAKE_TOOLCHAIN_FILE=$QT_ROOT_DIR/lib/cmake/Qt6/qt.toolchain.cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLITH_VERSION=$VERSION_NAME -DIOS_DEVELOPMENT_TEAM_ID=Z52EFCPL6D -DIMGUR_API_KEY=$IMGUR_API_KEY
 
 xcodebuild -project Lith.xcodeproj -destination generic/platform=iOS -scheme Lith -configuration RelWithDebInfo DEVELOPMENT_TEAM=Z52EFCPL6D build
 xcodebuild -project Lith.xcodeproj -scheme Lith -configuration RelWithDebInfo archive -archivePath Lith.xcarchive DEVELOPMENT_TEAM=Z52EFCPL6D

dist/macos/build.sh

@@ -3,5 +3,5 @@
 mkdir build_macos
 cd build_macos
 export CMAKE_PREFIX_PATH=$QT_ROOT_DIR/lib/cmake
-cmake .. -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" -DCMAKE_BUILD_TYPE=Release -DLITH_IMGUR_API_KEY=$IMGUR_API_KEY -DLITH_VERSION=$VERSION_NAME -DCMAKE_INSTALL_PREFIX=installed
+cmake .. -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" -DCMAKE_BUILD_TYPE=Release -DIMGUR_API_KEY=$IMGUR_API_KEY -DLITH_VERSION=$VERSION_NAME -DCMAKE_INSTALL_PREFIX=installed
 cmake --build . --parallel

dist/wasm/build.sh

@@ -7,6 +7,6 @@ pushd build_wasm
 
 export QT_HOST_PATH="${QT_ROOT_DIR}/../gcc_64"
 export CMAKE_PREFIX_PATH=$QT_ROOT_DIR/lib/cmake
-cmake .. -DCMAKE_BUILD_TYPE=Release -DLITH_IMGUR_API_KEY=$IMGUR_API_KEY -DCMAKE_INSTALL_PREFIX=installed -DCMAKE_TOOLCHAIN_FILE=$QT_ROOT_DIR/lib/cmake/Qt6/qt.toolchain.cmake
+cmake .. -DCMAKE_BUILD_TYPE=Release -DIMGUR_API_KEY=$IMGUR_API_KEY -DCMAKE_INSTALL_PREFIX=installed -DCMAKE_TOOLCHAIN_FILE=$QT_ROOT_DIR/lib/cmake/Qt6/qt.toolchain.cmake
 cmake --build .
 cmake --install .

modules/Lith/Core/cmakedefs.h.in

@@ -21,7 +21,7 @@
 #cmakedefine01 LITH_IS_DEBUG_BUILD
 #define CMAKE_BUILD_TYPE "${CMAKE_BUILD_TYPE}"
 
-#define LITH_IMGUR_API_KEY "${LITH_IMGUR_API_KEY}"
+#define IMGUR_API_KEY "${IMGUR_API_KEY}"
 
 #define LITH_INSTALL_MODULEDIR "${LITH_INSTALL_MODULEDIR}"
 

modules/Lith/Core/settings.h

@@ -173,7 +173,7 @@ class LITHCORE_EXPORT Settings : public QObject {
     // This is hidden for now
     SETTING(bool, terminalLikeChat, true)
 
-    SETTING(QString, imgurApiKey, QStringLiteral(LITH_IMGUR_API_KEY))
+    SETTING(QString, imgurApiKey, QStringLiteral(IMGUR_API_KEY))
 
     // UNUSED SETTINGS
     // determine what to do about these later