Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom Bar color on devices running SDK < 24 #47

Open
dellisd opened this issue Jun 2, 2019 · 3 comments
Open

Bottom Bar color on devices running SDK < 24 #47

dellisd opened this issue Jun 2, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@dellisd
Copy link
Member

dellisd commented Jun 2, 2019

Older devices don't support light coloured navigation bars. They should default to black (unless we opt for a full-colour option).
@dellisd dellisd added the bug Something isn't working label Jun 2, 2019
@GustavoSanMartin
Copy link
Member

@dellisd Could we just make it sdk 23 so we don't have to have a styles, styles-23, AND a styles-24?

@dellisd
Copy link
Member Author

dellisd commented Jun 11, 2019

sdk < 24 == sdk <= 23
We only need to override the styles-23

@GustavoSanMartin
Copy link
Member

ah quick maths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dellisd @GustavoSanMartin