change labels() method return type #58
Conversation
There was a problem hiding this comment.
👋 hi, thanks a lot for catching this issue and the contribution!
Due to having to support older versions of python I think the best course of action would be to use the typing_extensions library to make direct use of Self.
From my tests using "Self" would still mark it as unknown for pyright the returned object (although it fixes the error on the method).
Let me know if you want to work on it further or if you prefer for me to take over, regardless of choice I really appreciate you taking the time for raising and fixing this 🙌
So to recap the course of action would be:
- Add a dependency to typing_extensions
- Import
Selfwithout the need for theTYP_CHECKINGcheck - Replace
"Self"->Self
|
I agree that using typing_extensions is the better solution. I have made the requested changes, |
|
it actually doesn't seem to be enough as the return type now mismatch 😭 |
fix #57