Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle 401 for create #13

Open
mandarvaze opened this issue Sep 16, 2022 · 1 comment
Open

Gracefully handle 401 for create #13

mandarvaze opened this issue Sep 16, 2022 · 1 comment

Comments

@mandarvaze
Copy link
Member

For error code 401 (at least for Webhook.create) resp.body was empty ('') due to this JSON.parse(resp.body) crashes with JSON::ParserError Exception: 859: unexpected token at ''

See this code
@mandarvaze
Copy link
Member Author

@sumitsourav is this resolved ? If yes, can you add the commit SHA here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mandarvaze