Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest_stable_rust feature is out of date #288

Open
Lokathor opened this issue Dec 7, 2024 · 1 comment · May be fixed by #289
Open

latest_stable_rust feature is out of date #288

Lokathor opened this issue Dec 7, 2024 · 1 comment · May be fixed by #289
Labels
semver-patch semver patch change

Comments

@Lokathor
Copy link
Owner

Lokathor commented Dec 7, 2024

alloc_uninit, transparentwrapper_extra, and possibly other features that work on stable are not currently in the latest_stable_rust feature (which they should be).

@Lokathor Lokathor added the semver-patch semver patch change label Dec 7, 2024
@zachs18
Copy link
Contributor

zachs18 commented Dec 7, 2024

alloc_uninit is in the latest_stable_rust already, it just doesn't do anything if extern_crate_alloc is not also enabled, and latest_stable_rust doesn't include extern_crate_alloc (explicitly).

For future1 features which depend both on higher MSRV and alloc/std, I see two options:

  1. Have them be in latest_stable_rust, and have them just do nothing if extern_crate_alloc/extern_crate_std is not enabled (status quo for alloc_uninit)
  2. Have them not in latest_stable_rust, and have them depend on extern_crate_alloc/extern_crate_std
    a. Perhaps have new latest_stable_rust_alloc = ["latest_stable_rust", "extern_crate_alloc", "alloc_uninit", ...], latest_stable_rust_std = ["latest_stable_rust_alloc", "extern_crate_std", ...] features that enable all latest-stable features including ones that require alloc/std.

I looked, and it seems like other than transparentwrapper_extra, all other existing, sound, non-nightly, non-extern_crate_alloc/std features are included in latest_stable_rust, so I'll make a PR to add transparentwrapper_extra to latest_stable_rust.

Footnotes

  1. at this point I think it would be a breaking change to make alloc_uninit use option 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch semver patch change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants