Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub-specific defaults even if BuildVersionDisplay_BuildUrl is not supplied (OSOE-543) #4

Open
Piedone opened this issue Jan 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented Jan 17, 2023

Idea by @sebastienros:

When BuildVersionDisplay_BuildUrl is not supplied, still provide a default build link for GitHub Actions builds.

Assemblies built via GitHub Actions can have the commits hash suffixed to AssemblyInformationalVersion, and the repository URL available in AssemblyMetadata("RepositoryUrl", ...). See this for Helpful Libraries (opened in ILSpy):

image

I'm not sure where these are added, specifically, because I also checked one of our deployed app's Web project, and its assembly contains neither of these attributed. Perhaps it happens during NuGet publishing?

Jira issue

@Piedone Piedone added the enhancement New feature or request label Jan 17, 2023
@github-actions github-actions bot changed the title Use GitHub-specific defaults even if BuildVersionDisplay_BuildUrl is not supplied Use GitHub-specific defaults even if BuildVersionDisplay_BuildUrl is not supplied (OSOE-543) Jan 17, 2023
@Piedone
Copy link
Member Author

Piedone commented Oct 26, 2023

This is only needed if the given assembly is not built with one of our GitHub Actions that support BuildVersionDisplay_BuildUrl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant