-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure YAML linting (OSOE-759) #658
Comments
Regarding the rules I have one (currently), that I can't decide: Should we allow implicit Example for implicit |
I would allow it and seeing the linked example, I'd rather enforce an explicit null in this case (if it plays nicely with GitHub Actions), because whitespace (or lack thereof) should not have syntactical meaning (unless https://en.wikipedia.org/wiki/Whitespace_%28programming_language%29 :D), but YAML is a language where indentation has syntactical meaning, so it's sort of a contradiction. |
Are there any similar examples? Because |
Well there is actually an interesting scenario, in case of
(https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/workflows/validate-this-gha-refs.yml#L6) The
Do we want to use the rule still? |
Then not, but still fix the two maintenance secrets. |
Is this necessary? The workflow in OSOCE (https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/blob/dev/.github/workflows/build-and-test.yml#L73-L78) checks the submodules too. I already fixed the warnings in them. |
Then no, not necessary. |
After Lombiq/NodeJs-Extensions#11, configure the YAML linting rules of
yamllint
as it's fitting for our projects.Jira issue
The text was updated successfully, but these errors were encountered: