Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update result-service.yaml #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update result-service.yaml #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion k8s-specifications/result-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ spec:
- name: "result-service"
port: 5001
targetPort: 80
nodePort: 31001
nodePort: 31002
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Port 31002 is already in use by vote-service.yaml. Please choose a different nodePort to avoid conflicts.

🔗 Analysis chain

LGTM! Verify port availability and update related configs.

The change from nodePort: 31001 to nodePort: 31002 looks good. The new port is within the valid range for NodePorts (30000-32767).

Please run the following command to ensure that the new port (31002) is not already in use by another service in the cluster:

If the command returns any service names, it indicates a potential conflict that needs to be resolved.

Don't forget to update any related documentation, deployment scripts, or other configuration files that might reference the old port number (31001).

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if port 31002 is already in use
kubectl get services --all-namespaces -o json | jq '.items[] | select(.spec.ports[]?.nodePort==31002) | .metadata.name'

Length of output: 196

Script:

#!/bin/bash
# Search for any occurrence of nodePort: 31002 in YAML files
rg 'nodePort:\s*31002' --files-with-matches --glob '*.yaml'

Length of output: 137

selector:
app: result