Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changing plus to minus #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: changing plus to minus #6

wants to merge 1 commit into from

Conversation

gordonworldlee
Copy link

@gordonworldlee gordonworldlee commented Feb 26, 2025 •
edited
Loading

Screenshot 2025-02-25 at 8 18 44 PM Screenshot 2025-02-25 at 8 19 04 PM Fixes #1

@gordonworldlee gordonworldlee marked this pull request as draft February 26, 2025 02:21
@gordonworldlee gordonworldlee marked this pull request as ready for review February 26, 2025 02:22
@gordonworldlee gordonworldlee changed the title feat: changing plus to minus chore: changing plus to minus Feb 26, 2025
doprz
doprz requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm-lock.yaml shouldn't be modified

@doprz
Copy link
Contributor

doprz commented Feb 26, 2025

Also make sure that all tests are passing

@DereC4
Copy link
Member

DereC4 commented Feb 27, 2025

image

like the fork name 👍

@DereC4 DereC4 self-requested a review February 27, 2025 12:39
DereC4
DereC4 reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@DereC4 DereC4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if this will help in this case but run

git checkout -- .\pnpm-lock.yaml

Samathingamajig
Samathingamajig approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for learning sandbox purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DereC4 DereC4 DereC4 left review comments

@doprz doprz doprz requested changes

@Samathingamajig Samathingamajig Samathingamajig approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@gordonworldlee gordonworldlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[chore] Change all branding to UT Registration Minus
4 participants
@gordonworldlee @doprz @DereC4 @Samathingamajig