From d454a745ccc1a35ad1548fcf6feae72b843833ce Mon Sep 17 00:00:00 2001 From: CBroz1 Date: Thu, 20 Feb 2025 17:40:22 -0600 Subject: [PATCH] #1231 --- .github/workflows/test-conda.yml | 2 ++ CHANGELOG.md | 1 + notebooks/00_Setup.ipynb | 4 ++-- notebooks/py_scripts/00_Setup.py | 4 ++-- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-conda.yml b/.github/workflows/test-conda.yml index 6ff4437e4..434ca508a 100644 --- a/.github/workflows/test-conda.yml +++ b/.github/workflows/test-conda.yml @@ -33,6 +33,8 @@ jobs: ports: - 3308:3306 options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 + cap_add: # https://stackoverflow.com/questions/55559386 + - SYS_NICE # CAP_SYS_NICE steps: - name: Checkout uses: actions/checkout@v4 diff --git a/CHANGELOG.md b/CHANGELOG.md index 7814553d0..3bd896fae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - Update URL for DANDI Docs #1210 - Improve cron job documentation and script #1226 - Only add merge parts to `source_class_dict` if present in codebase #1237 +- Edit docker security settings to quiet `mbind` warnings #1242 ### Pipelines diff --git a/notebooks/00_Setup.ipynb b/notebooks/00_Setup.ipynb index 2fcdf40eb..489e8c156 100644 --- a/notebooks/00_Setup.ipynb +++ b/notebooks/00_Setup.ipynb @@ -384,7 +384,7 @@ " - Port mapping. Here, we map 3306 across the local machine and container.\n", "\n", " ```bash\n", - " docker run --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0\n", + " docker run --cap-add=sys_nice --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0\n", " ```\n", "\n", "- For data to persist after terminating the container,\n", @@ -392,7 +392,7 @@ "\n", " ```bash\n", " docker volume create dj-vol\n", - " docker run --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql\n", + " docker run --cap-add=sys_nice --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql\n", " ```\n", "\n", "Docker credentials are as follows:\n", diff --git a/notebooks/py_scripts/00_Setup.py b/notebooks/py_scripts/00_Setup.py index a3ef6a006..ddd564738 100644 --- a/notebooks/py_scripts/00_Setup.py +++ b/notebooks/py_scripts/00_Setup.py @@ -325,7 +325,7 @@ # - Port mapping. Here, we map 3306 across the local machine and container. # # ```bash -# docker run --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0 +# docker run --cap-add=sys_nice --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0 # ``` # # - For data to persist after terminating the container, @@ -333,7 +333,7 @@ # # ```bash # docker volume create dj-vol -# docker run --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql +# docker run --cap-add=sys_nice --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql # ``` # # Docker credentials are as follows: