Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept activeAnimationId as part of the Config #182

Closed
theashraf opened this issue Jun 19, 2024 · 1 comment
Closed

feat: accept activeAnimationId as part of the Config #182

theashraf opened this issue Jun 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@theashraf
Copy link
Member

The default activeAnimationId is set to either the first animation in the .lottie file or the animation ID specified in the manifest.activeAnimationId. Currently, when load_dotlottie_data is called, this default behavior cannot be overridden. This means users need to make an additional request using the load_animation method to load a different animation if needed.

To address this, we could introduce activeAnimationId to the Config. This would allow users to easily specify which animation should be loaded initially, simplifying the process.

related LottieFiles/dotlottie-web#250

@theashraf theashraf added the enhancement New feature or request label Jun 19, 2024
@theashraf
Copy link
Member Author

If animation_id is included in the config, it would be difficult to determine whether a change in animation_id was successful. However, with the load_animation method, we can easily verify this.

It may not be necessary to introduce animation_id as part of the config; this can likely be abstracted by the frameworks, as demonstrated here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant