Skip to content

Commit

Permalink
SI-42 Fix approval_filter being ignored in list_requests (missing quote)
Browse files Browse the repository at this point in the history
Apparently if you don’t quote the value then that clause somehow evaluates to true!
  • Loading branch information
dwrss committed Jun 19, 2024
1 parent aa73c9d commit ac12554
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion botto/storage/beta_testers/beta_testers_storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def list_requests(
case RequestApprovalFilter.UNAPPROVED:
formula += f",OR({{Approved}}=FALSE(),{{Status}}=BLANK())"
case RequestApprovalFilter.APPROVED:
formula += f",OR({{Approved}}=TRUE(),{{Status}}={RequestStatus.APPROVED.value})"
formula += f",OR({{Approved}}=TRUE(),{{Status}}='{RequestStatus.APPROVED.value}')"
if exclude_removed:
formula += f",{{Removed}}=FALSE()"
formula += ")"
Expand Down

0 comments on commit ac12554

Please sign in to comment.