Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a hold leaves lingering moves in the UI #2

Open
LucasPickering opened this issue Jul 25, 2022 · 0 comments
Open

Deleting a hold leaves lingering moves in the UI #2

LucasPickering opened this issue Jul 25, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@LucasPickering
Copy link
Owner

If you delete a hold that haves moves on it, then the hold disappears but the moves still show in the UI until you refresh the page.

image
image

This is because the deleteHold mutation only returns the deleted hold, which we can purge from Relay, but it doesn't return any info about the deleted moves, because those are deleted implicitly by the DB due to cascading.

This will be a bit of a pain to fix, so I'm ignoring it for now because I don't expect it to be a common scenario. If you've gotten far enough along to start adding beta, then the tagged hold is probably legit and won't need to be deleted.

@LucasPickering LucasPickering added the bug Something isn't working label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant