Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate3D preventing ng-gallery to go fullscreen #37

Closed
PabloMDiez opened this issue Jan 19, 2016 · 5 comments
Closed

translate3D preventing ng-gallery to go fullscreen #37

PabloMDiez opened this issue Jan 19, 2016 · 5 comments

Comments

@PabloMDiez
Copy link

Hey there! Thanks for the hard work 👍
I'm using v-Accordion and inside it, I've put a ng-gallery component. When you click on a image, it is supposed to overlay the full screen. The thing is that it only overlays v-pane-content.
I've asked this on ng-gallery issues and StackOverflow.
Given a comment there and another similar issue posted on ng-gallery wiki, I realized it has something to do with v-Accordion's translate3d CSS property.
Do you know any workaround so I can keep ng-gallery inside an accordion, but allowing it to cover the whole body?
Thanks!

@LukaszWatroba
Copy link
Owner

Hey! Sorry for late reply.

I never use ng-gallery inside v-accordion, but if this is really an issue with translate3d CSS property, the only workaround that comes to my mind is to simply override v-accordion default styling, like so:

.vAccordion--default v-pane-content > div {
  transform: none;
}

.vAccordion--default v-pane.is-expanded > v-pane-content > div {
  transform: none;
}

@PabloMDiez
Copy link
Author

Thanks a lot for your response!
I tried it, putting that code in v-acordion.scss. Also tried adding !important to those lines, and even modifying it's other source files where translate3d was to none.
Still the same :(

@LukaszWatroba
Copy link
Owner

Try to use the v1.5.1 release, remember to override v-pane-content translate3d property and let me know if this helps.
On 1.4.x I was using will-change property witch similarly to translate3d also creates a new compositing layer.

@LukaszWatroba
Copy link
Owner

For now, I'll close the issue, but feel free to re-open if you're still having problems.

@PabloMDiez
Copy link
Author

Fixed with 1.5.1!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants