New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients Dockerfile.env comments do not match implementation #8

Open

jEnbuska opened this issue Apr 20, 2021 · 0 comments

jEnbuska commented Apr 20, 2021 •

edited

Loading

At https://github.com/LukeMwila/multi-container-nginx-react-node-mongo/blob/master/client/Dockerfile.dev there seems to be inconsistency between comments and implementation

...
# A wildcard is used to ensure both package.json AND package-lock.json are copied
COPY package.json .

## install only the packages defined in the package-lock.json (faster than the normal npm install)
RUN npm install
...

Potential issues:

package.lock.json is not copyed
package.lock.json is not used for installation

Is this what the implementation should be looked like?:

...
# A wildcard is used to ensure both package.json AND package-lock.json are copied
COPY package.* .

## install only the packages defined in the package-lock.json (faster than the normal npm install)
RUN npm ci
...

The text was updated successfully, but these errors were encountered:

jEnbuska changed the title ~~clinet Dockerfile.env~~ clients Dockerfile.env comments do not match implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment